Sequence search track #3159
Merged
Sequence search track #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
sequence_track_search
branch
from
6d4a82b
to
0dcf3b6
Compare
Codecov Report
@@ Coverage Diff @@
## main #3159 +/- ##
==========================================
- Coverage 58.80% 58.65% -0.15%
==========================================
Files 648 663 +15
Lines 29048 29159 +111
Branches 7069 7086 +17
==========================================
+ Hits 17081 17104 +23
- Misses 11588 11676 +88
Partials 379 379
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
force-pushed
the
sequence_track_search
branch
2 times, most recently
from
dc884a6
to
b0928c9
Compare
cmdcolin
force-pushed
the
sequence_track_search
branch
from
b0928c9
to
e6c6518
Compare
cmdcolin
force-pushed
the
sequence_track_search
branch
from
78d4bfd
to
ea4a636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of sequence search track
It allows a user to pop up a dialog in the linear genome view menu, and it uses a SequenceSearchAdapter to match data, with a single assembly's sequence adapter as a subadapter
Also refactors some code in the sequence plugin so that each pluggable element registers itself instead of being a lengthy process inside of plugins/sequence/src/index.ts
Addresses #3150
Note that this uses static blocks, it could potentially use dynamic blocks to help avoid issues around the block boundary, but then might need a custom display type, which is a bit trickier than just saying that it is a plain FeatureTrack with the SequenceSearchAdapter